Skip to content

[scripts] Fix fix_data_dir.sh bug introduced in #2414; thanks, @Fhrozen#2439

Merged
danpovey merged 1 commit intokaldi-asr:masterfrom
danpovey:script_fix
May 21, 2018
Merged

[scripts] Fix fix_data_dir.sh bug introduced in #2414; thanks, @Fhrozen#2439
danpovey merged 1 commit intokaldi-asr:masterfrom
danpovey:script_fix

Conversation

@danpovey
Copy link
Contributor

No description provided.

@danpovey
Copy link
Contributor Author

Resolves #2438. @Ore-an, please note: that 'true' was needed to ensure the function had zero return status. Due to set -e, it causes the script to exit prematurely if it returns nonzero.

@danpovey danpovey merged commit 264a6a3 into kaldi-asr:master May 21, 2018
@Ore-an
Copy link
Contributor

Ore-an commented May 22, 2018

Sorry about that, I probably didn't notice it was inside the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments